Advance velox #202
Open
Advance velox #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this in D77891586. |
Yuhta
approved these changes
Jul 7, 2025
kevinwilfong
force-pushed
the
advance_velox
branch
5 times, most recently
from
77fb246 to
10416d5
Compare
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this in D77891586. |
kevinwilfong
force-pushed
the
advance_velox
branch
3 times, most recently
from
d13b7a4 to
61a19ad
Compare
kevinwilfong
force-pushed
the
advance_velox
branch
from
61a19ad to
5fcc2df
Compare
kou
reviewed
Jul 8, 2025
| flex \ | ||
| libfl-dev | ||
| libfl-dev \ | ||
| libgeos++-dev |
There was a problem hiding this comment.
It seems that libgeos++-dev in Ubuntu 22.04 is broken. /usr/lib/x86_64-linux-gnu/cmake/GEOS/geos-targets.cmake has -DGEOS_INLINE but libgeos++-dev doesn't include geos/geom/Coordinate.inl. Can we use bundled GEOS instead of system GEOS in our CI?
FAILED: [code=1] velox/velox/functions/prestosql/geospatial/CMakeFiles/velox_functions_geo.dir/GeometrySerde.cpp.o
ccache /usr/bin/clang++-15 -DBOOST_CONTAINER_NO_LIB -DBOOST_CONTAINER_STATIC_LINK -DBOOST_CONTEXT_EXPORT="" -DBOOST_CONTEXT_NO_LIB="" -DBOOST_CONTEXT_STATIC_LINK="" -DBOOST_FILESYSTEM_NO_LIB -DBOOST_FILESYSTEM_STATIC_LINK=1 -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_PROGRAM_OPTIONS_STATIC_LINK -DBOOST_RANDOM_NO_LIB -DBOOST_RANDOM_STATIC_LINK -DDISABLE_META_INTERNAL_COMPRESSOR=1 -DGEOS_INLINE -DGFLAGS_IS_A_DLL=0 -DNDEBUG -DUSE_UNSTABLE_GEOS_CPP_API -DVELOX_DISABLE_GOOGLETEST -DVELOX_ENABLE_PARQUET -I/home/runner/work/nimble/nimble/nimble/_build/release -I/home/runner/work/nimble/nimble/nimble/. -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/protobuf-src/src -I/home/runner/work/nimble/nimble/nimble/velox/. -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/fmt-src/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/algorithm/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/array/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/assert/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/config/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/core/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/static_assert/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/throw_exception/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/bind/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/concept_check/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/preprocessor/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/type_traits/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/exception/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/smart_ptr/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/move/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/tuple/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/function/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/iterator/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/detail/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/function_types/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/mpl/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/predef/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/utility/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/io/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/fusion/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/container_hash/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/describe/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/mp11/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/typeof/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/functional/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/optional/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/range/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/conversion/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/regex/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/unordered/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/context/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/pool/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/integer/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/winapi/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/filesystem/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/system/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/variant2/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/program_options/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/any/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/type_index/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/lexical_cast/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/container/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/intrusive/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/numeric/conversion/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/headers/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/crc/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/circular_buffer/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/math/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/random/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/dynamic_bitset/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/multi_index/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/multiprecision/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/uuid/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/tti/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/boost-src/libs/variant/include -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/re2-src -I/home/runner/work/nimble/nimble/nimble/_build/release/_deps/absl-src -isystem /home/runner/work/nimble/nimble/nimble/velox -isystem /home/runner/work/nimble/nimble/nimble/velox/velox/external/xxhash -isystem /home/runner/work/nimble/nimble/nimble/_build/release/_deps/xsimd-src/include -isystem /home/runner/work/nimble/nimble/nimble/velox/velox -isystem /home/runner/work/nimble/nimble/nimble/velox/velox/external -isystem /home/runner/work/nimble/nimble/nimble/_build/release/_deps/folly-src -isystem /home/runner/work/nimble/nimble/nimble/_build/release/_deps/folly-build -isystem /home/runner/work/nimble/nimble/nimble/_build/release/_deps/folly-src/Boost_INCLUDE_DIR-NOTFOUND -isystem /home/runner/work/nimble/nimble/nimble/_build/release/_deps/fastfloat-src/include -isystem /usr/include/libdwarf -isystem /usr/include/geos -Wno-deprecated-declarations -Wno-unknown-warning-option -Wno-nullability-completeness -mavx2 -mfma -mavx -mf16c -mlzcnt -mbmi2 -mavx2 -mfma -mavx -mf16c -mlzcnt -mbmi2 -D USE_VELOX_COMMON_BASE -D HAS_UNCAUGHT_EXCEPTIONS -DFOLLY_CFG_NO_COROUTINES -Wall -Wextra -Wno-unused -Wno-unused-parameter -Wno-sign-compare -Wno-ignored-qualifiers -Wno-range-loop-analysis -Wno-mismatched-tags -Wno-nullability-completeness -O3 -DNDEBUG -std=gnu++20 -fPIC -fcolor-diagnostics -ffp-contract=off -MD -MT velox/velox/functions/prestosql/geospatial/CMakeFiles/velox_functions_geo.dir/GeometrySerde.cpp.o -MF velox/velox/functions/prestosql/geospatial/CMakeFiles/velox_functions_geo.dir/GeometrySerde.cpp.o.d -o velox/velox/functions/prestosql/geospatial/CMakeFiles/velox_functions_geo.dir/GeometrySerde.cpp.o -c /home/runner/work/nimble/nimble/nimble/velox/velox/functions/prestosql/geospatial/GeometrySerde.cpp
In file included from /home/runner/work/nimble/nimble/nimble/velox/velox/functions/prestosql/geospatial/GeometrySerde.cpp:17:
In file included from /usr/include/geos/geom/CoordinateArraySequence.h:21:
In file included from /usr/include/geos/geom/CoordinateSequence.h:21:
/usr/include/geos/geom/Coordinate.h:164:11: fatal error: 'geos/geom/Coordinate.inl' file not found
# include "geos/geom/Coordinate.inl"
^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
There was a problem hiding this comment.
We can revert this change because facebookincubator/velox#14103 has been merged.
Now, we can build Velox with set(VELOX_ENABLE_GEO OFF).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, need to advance velox to pull in facebookincubator/velox#14012 so we can fix the API call here.